[MAGNOLIA-2060] Rename JspTemplateRenderer to DefaultTemplateRenderer Created: 14/Feb/08 Updated: 17/Mar/09 Resolved: 19/Jan/09 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | templating |
| Affects Version/s: | 3.5.4 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Jan Haderka | Assignee: | Philipp Bärfuss |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: |
| Description |
|
It was shown in recent integration efforts that JspTemplateRenderer is robust and flexible enough to serve not only jsp based templates but also for example Spring Controller or Wicket based page templates. But it is confusing to for people to be told to use JspTemplateRenderer when what they want to render is not jsp at all. |
| Comments |
| Comment by Magnolia International [ 19/Jan/09 ] |
|
Not the case anymore. We now have AbstractRenderer which takes care of setting most of the context variables and so on. Further refactoring should further improve the cases where custom renderers are needed for integration purposes, but the JspTemplateRenderer can't be renamed to Default* now. |