[MAGNOLIA-2124] I18nContentSupport for dialogs Created: 24/Apr/08 Updated: 10/Sep/10 Resolved: 10/Sep/10 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | gui |
| Affects Version/s: | 3.6 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major |
| Reporter: | Stojan Peshov | Assignee: | Philipp Bärfuss |
| Resolution: | Outdated | Votes: | 2 |
| Labels: | i18n, toreview | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Irrelevant |
||
| Attachments: |
|
||||||||||||||||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Patch included: |
Yes
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Description |
|
In For this functionality we modified the following:
We attached the patch and hope that you'll like it. p.s. we also have created a language chooser (changer) tag that successfully implements the suggested solution |
| Comments |
| Comment by Philipp Bracher [ 25/Apr/08 ] |
|
I changed the fix version to 3.6 in the hope that we can apply the patch. Many thanks! |
| Comment by Magnolia International [ 27/Jun/08 ] |
|
Please check |
| Comment by Philippe Marschall [ 04/Jul/08 ] |
|
Sorry but this does not sound very useful. There are always properties which you don't want to translate. Examples include:
I hope there will be a way to disable this and switch to the old behavior. |
| Comment by Stojan Peshov [ 04/Jul/08 ] |
|
That is very subjective idea.
Maybe it's easier to change the language in the dialog, but what happens when you have 10+ languages? And I think the best feature of all is that if you leave some nodeData field empty in the secondary language, the page will always use the primary (fallback) language field. This is also an answer to your images, links, dates problem. We already have implemented this concept on a live web site (jug.mk) and works just fine. Regards |
| Comment by Philippe Marschall [ 04/Jul/08 ] |
|
I didn't say there are cases where you want everything to be "translated". What I'm saying is there are cases when i don't want everything to be translated. With the state of affairs in Magnolia 3.5 I can do that. With our proposal I can't do that. |
| Comment by Vasko Gjurovski [ 04/Jul/08 ] |
|
Hi Philippe, If you do not want translate something, you do not have to translate However, there is a small problem with the different number of As every idea, perhaps it needs a little more development and testing, Regards.. |
| Comment by Philippe Marschall [ 04/Jul/08 ] |
|
I haven't looked at in detail but as far as I understand time based activation is not i18n aware. A whole node is activated and not simply some of its properties. Excuse we if I'm wrong here. So what will happen is the user can set different activation dates for different languages simply because he can. Then he'll find out that it doesn't work. |
| Comment by Stojan Peshov [ 07/Jul/08 ] |
|
Hmm, you are absolutely right. As long as activation isn't i18n aware, my point is worthless. I haven't seen the activation workflow in details, but i assume that it can be easily adjusted to activate only the current language. I've been thinking lately about other workaround. A simple (i18nIgnore) property added in the dialog in config could give us the ability to exclude some of the fields from i18n saving mechanism. There should be minor modifications in Save class for this functionality. |
| Comment by Philippe Marschall [ 07/Jul/08 ] |
|
Yes an additional property to disable it for a given node would invalidate all my objections. |
| Comment by Philipp Bracher [ 08/Jul/08 ] |
|
Some days ago I quickly locked at the patch and then finally resisted to apply it. A share the concerns of Philipp Marschall. I also thought on introducing a flag (controls, or tab level). The dialog would then add the additional controls for i18n controls/tabs (same result as you have now but less copy pasting, easy adding of new language). For the most users it is important to have the original message in the same dialog in which they translate. May I invite you to start a concept page here: http://wiki.magnolia.info/display/DEV/Concept+i18n+next+steps Note about activation: I consider it best to separate the i18n content from the real content. So that per language activation should be trivial. The i18n support was original designed in that perspective. The nodedata is not necesserely stored under the same node. Actually not even in the same workspace. |
| Comment by Magnolia International [ 10/Jul/08 ] |
|
pushing to next version - needs more discussion |
| Comment by Vasko Gjurovski [ 22/Jul/08 ] |
|
Ok, it looks like there is a need to separate the nodes that can be localized and those that don't. So why don't do it? Just separate the nodes in to two types (config nodes and content nodes, or any other terminology that suites better)? I haven't looked at the code but I believe that it is not more than just a method isNodeContentNode() that can be configurable in the admin central (like the node type and name are configured). It would be by default false. This way we can make difference between the conifg nodes (those that do not need to be localized) and content nodes (those that can be localized). |
| Comment by Vasko Gjurovski [ 02/Oct/08 ] |
|
Updated version of the patch for Magnolia 3.6.1, due to core changes in the i18n classes |
| Comment by Vasko Gjurovski [ 05/Oct/08 ] |
|
I just managed to read through all of Genuine Overvie (it is loong |