[MAGNOLIA-2126] Block Level Tags Incorrectly Applied in FCK Editor Created: 29/Apr/08  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 3.5.4
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Sean McMains Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

FCK Editor in its standard configuration removes surrounding P tags when applying a block-element tag via the style menu. In Magnolia, it incorrectly leaves the P tag in place while putting a block-level tag within the P tag.

To reproduce:

1. Create a new Samples: Editor paragraph
2. Enter a few words of text
3. Press return
4. Press the "source" button
5. Note that the first line is now correctly wrapped in <p> and </p> tags.
6. Press "source" again to return to visual edit mode
7. Select the first line of text.
8. Choose "Page Title" from the Style menu
9. Click the "source" button again

Expected behavior:

The <p> tags should have been replaced with <h1> tags. This is how FCK Editor 2.4.3 does things if you download it and run it outside of the context of Magnolia. Since it works correctly in FCKEditor normally, it appears the issue is caused in some way by integration with Magnolia.

<h1>text</h1>

Actual behavior:

The <h1> tags are wrapped in the original <p> tags – an invalid HTML construct – like so:

<p>
<h1>text</h1>
</p>

At this point, if you go back and forth between source and visual mode again, or save the paragraph, FCK Editor notices the invalid structure and tries to fix it for you, resulting in a couple of extra empty paragraphs. (It was these extra paragraphs that started our customers complaining about this issue.)

<p>&nbsp;</p>
<h1>text</h1>
<p>&nbsp;</p>


 Comments   
Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:33:40 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.