[MAGNOLIA-2128] BaseContentTag.getFirstMatchingNode() should search for contentNode in parent pages when inherit == true Created: 05/May/08  Updated: 23/Jan/13  Resolved: 11/Jul/08

Status: Closed
Project: Magnolia
Component/s: taglibs
Affects Version/s: 3.5.4
Fix Version/s: 3.6

Type: Improvement Priority: Major
Reporter: Thomas Duffey Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File BaseContentTag.java.inherit.patch    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

I was expecting to be able to do something simple like this in a JSP:

<cms:out contentNodeName="footerPar" nodeDataName="footerText" inherit="true"/>

Unfortunately, BaseContentTag.getFirstMatchingNode() exits too soon when on a child page that does not have its own "footerPar" node. Parent pages should be searched for this content node to make inheriting with cms:out more useful.

See attached patch.



 Comments   
Comment by Magnolia International [ 09/Jul/08 ]

Thanks for the patch ! Will apply soon, if no template issues are discovered.

Comment by Magnolia International [ 11/Jul/08 ]

Patch applied, thanks !

Generated at Mon Feb 12 03:33:41 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.