[MAGNOLIA-2143] FCK Editor should not surround text with a P-Tag Created: 21/May/08  Updated: 23/Jan/13  Resolved: 07/Jul/08

Status: Closed
Project: Magnolia
Component/s: admininterface, fckeditor, gui
Affects Version/s: 3.5.4
Fix Version/s: 3.6

Type: Improvement Priority: Major
Reporter: Giancarlo Berner Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Mg 3.5.4, FF, Mac OS X (Leopard), Tomcat 5.5


Issue Links:
duplicate
relation
is related to MAGNOLIA-2252 Properties enterMode and shiftEnterMo... Closed
is related to MAGNOLIA-2253 FCKEditor Bug in Internet Explorer 6-7 Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   
  • Add some text
  • Save
    The fckEdit control surrounds the text with a P-tag. This is very disturbing and should please be removed (or configurable).
  • Add some text
  • Click Enter
  • Add some more text
    The fckEdit add's P-Tags instead of BR tags.

Is there a configuration possibility, patch or other work around available?

Thanks!



 Comments   
Comment by Fabrizio Giustina [ 21/May/08 ]

this can be configured in FckEdit (not sure about the version), maybe we should expose this configuration option in the dialogs:

FCKConfig.EnterMode = 'br'
// Accepted values are 'p', 'div', and 'br'.

Comment by Magnolia International [ 10/Jun/08 ]

for the record, this is in the fckconfig.js file.

The defaults are:
FCKConfig.EnterMode = 'p' ;
FCKConfig.ShiftEnterMode = 'br'

Which imho

  • are good defaults: semantically, paragraphs of text (i.e what you do when hit the enter/return key is, typographically, creating a new paragraph) should be surrounded by <p> tags. If you don't like the way it looks, learn and fix your css.
  • shows that you can even be nasty and work à la ms-word, force simple line breaks with the shift-enter key combination.

As for adding this to the configuration option... I supposed you meant at control level, but then again, there are plenty of other options which aren't supported right now - so supporting them all (and possibly aligning the options currently used with their actual name in fck) is probably a simpler and better option for us. (adding this to the fck dialog itself would seem overkill - and probably just confusing for end users)

Comment by Philipp Bracher [ 07/Jul/08 ]

Is now configurable (default values are the same as fck editors defaults)

  • enterMode: p
  • shiftEnterMode: br
Generated at Mon Feb 12 03:33:50 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.