[MAGNOLIA-2175] Configurable controls/dialogs (use Content2Bean in controls configuration) Created: 07/Jun/08  Updated: 19/Dec/16  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: gui
Affects Version/s: 3.5.8
Fix Version/s: None

Type: Improvement Priority: Major
Reporter: Fabrizio Giustina Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Controls are actually loaded explicitly only using their class name, for example:

config:/modules/adminInterface/controls/freemarker/class = info.magnolia.cms.gui.dialog.DialogFreemarker.java

without using Content2Bean, so it's not possible to make them parametric and to configure them. Especially for the freemarker dialog this could be really useful, in order to create a specific control (for example "grid") backed by a fixed ftl template.
In order to do this, info.magnolia.cms.gui.dialog.ControlsManager needs to be modified in order to use Content2Bean, but we also need to modify how dialogs are registered and reused (currently not by instance but by class).



 Comments   
Comment by Fabrizio Giustina [ 07/Jun/08 ]

a few changes to existing controls needed in order to make this possible:

  • all the info.magnolia.cms.gui.dialog.Dialog* have protected constructor which needs to be turned to public in order to be able to instantiate them using FactoryUtils
  • DialogControl must extends Cloneable, so that we can save a single configured instance in the registry, but create a copy at each use (it's definitively not a singleton...)

any thought on applying those changes for 3.6?

Comment by Magnolia International [ 09/Jul/08 ]

Pushing this back to 3.6.1, but it might end up being pushed further (unless a contribution pops in of course )

Comment by Jan Haderka [ 02/Sep/08 ]

Looks more like new target for this improvement will be 3.7

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:34:09 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.