[MAGNOLIA-2221] Validate html and js Created: 01/Jul/08  Updated: 23/Jan/13  Resolved: 14/Dec/09

Status: Closed
Project: Magnolia
Component/s: admininterface
Affects Version/s: 3.6-m2
Fix Version/s: None

Type: Improvement Priority: Major
Reporter: Fabrizio Giustina Assignee: Magnolia International
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-2793 HTML issues in trees Closed
is related to MAGNOLIA-2224 Display of inbox is corrupted. Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Most of the admin interface pages and dialogs doesn't validates due to errors in the html such as:

  • missing doctypes
  • bad nesting of tags (invalid tags in forms, tables missing tr's)
  • css/javascript working only in legacy mode due to missing units (px) on css attributes for sizing/positioning

in order to improve compatibility with recent browser we should fix those errors and validate all the code. Working in non-standard mode (no doctype) is really bad for compatibility.

I already started to fix some of the errors for 3.6, and I'll try to fix some more of them. Installing the html validator extension for firefox ( http://users.skynet.be/mgueury/mozilla/ ) is recommended for any developer



 Comments   
Comment by Jan Haderka [ 02/Jul/08 ]

Fabrizio, I had to revert change to AdminTreeMVCHandler as it broke the AdminCentral in FF. Could you please look at it? Thanks. Jan

Comment by Fabrizio Giustina [ 02/Jul/08 ]

it's probably due to invalid css/javascript which is not evaluated in standard compliance mode, I'll check it more carefully before applying the fix for the html. Thanks Jan

Comment by Magnolia International [ 11/Jul/08 ]

Some fixes were done for 3.6, but will be an ongoing process for next versions; however, we'd like to only fix things that are actually broken, since these changes tend to introduce a lot of side effects. Of course we'll take care of this with 4.0, since we're targetting a complete ui overhaul then.

Comment by Magnolia International [ 19/Jun/09 ]

I noticed a bunch of pages which the following invalid doctype:

{fixed}
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">{fixed}

It should be

{fixed}
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">{fixed}

Unfortunately, fixing this makes firefox and other browsers move from quirks mode to standards-compliance mode, and might have quite some impact on rendering of trees, lists, ...

Comment by Boris Kraft [ 09/Dec/09 ]

I suggest to close this as unresolved as we will completely rewrite the GUI for 5.0 anyways.

Comment by Philipp Bärfuss [ 14/Dec/09 ]

I agree. It is partially fixed and otherwise we wont do anything unless something is not working anymore.

Generated at Mon Feb 12 03:34:35 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.