[MAGNOLIA-2240] CacheFilter should check its configuration and disable itself if it's invalid Created: 09/Jul/08  Updated: 23/Jan/13  Resolved: 09/Jul/08

Status: Closed
Project: Magnolia
Component/s: cache
Affects Version/s: 3.6-m3
Fix Version/s: 3.6

Type: Bug Priority: Major
Reporter: Magnolia International Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

This issue was discovered because the CacheFilter class should have had a "cacheConfigurationName" instead of "cacheConfiguration". The actual variable had the correct name and so did the bootstrap file, but the getter/setter pair was wrong; as a result, the default cache config was always used.

  • If the cacheConfigurationName isn't set, we will output a warning log statement and fallback to the default (instead of assigning the default value to the variable on initialization)
  • If the module can't return a Cache or CacheConfiguration from cacheConfigurationName, we will output an error log statement and disable the filter. (once the configuration is fixed the filter gets reloaded through the magic of CacheModuleLifecycleListener)


 Comments   
Comment by Magnolia International [ 09/Jul/08 ]

done on trunk

Generated at Mon Feb 12 03:34:46 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.