[MAGNOLIA-2319] WebXmlUtil.areFilterDispatchersConfiguredProperly method is overly strict Created: 12/Aug/08  Updated: 23/Jan/13  Resolved: 22/Jan/09

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: None
Fix Version/s: 4.0, 3.6.4, 3.6.5

Type: Bug Priority: Major
Reporter: Dallas Vaughan Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

This method is called within the info.magnolia.module.delta.WebXmlConditionsUtil.filterMustBeRegisteredWithCorrectDispatchers method, to test that there are REQUEST and FORWARD dispatchers configured in the web.xml file before starting/installing the core module.

However, in our case we have added the INCLUDE dispatcher in order to enable inclusion of magnolia content into other web apps. Since this test only passes if there are only these two dispatchers configured (with optional "ERROR"), it fails even if these 2 dispatchers are present along with the INCLUDE. This prevents the core module from installing on bootstrapped startup.

I think it should only test the mandatory presence of REQUEST and FORWARD, and not validate additional dispatchers.



 Comments   
Comment by Magnolia International [ 13/Aug/08 ]

We had to enforce this due due to some problems with jsp includes. This might be irrelevant now, however, so we should double check this.

Comment by Magnolia International [ 09/Sep/08 ]

Will attempt to check if this is still relevant with 3.6.2

Comment by Magnolia International [ 22/Jan/09 ]

Thanks for the report - fix committed to 3.6 branch and trunk !

Generated at Mon Feb 12 03:35:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.