[MAGNOLIA-2331] WARN: session has been already closed Created: 19/Aug/08  Updated: 23/Jan/13  Resolved: 23/Jan/09

Status: Closed
Project: Magnolia
Component/s: workflow
Affects Version/s: 3.6.1
Fix Version/s: 4.0

Type: Bug Priority: Minor
Reporter: Sameer Charles Assignee: Jan Haderka
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-2301 Superflous logout from jcr session on... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

I have the following exception and related WARN each time I activate a website node.
Default installation, no changes to workflow etc..

This happens always:
IWARN info.magnolia.context.AbstractRepositoryStrategy AbstractRepositoryStrategy.java(release:153) 19.08.2008 17:25:58 session has been already closed website
WARN info.magnolia.context.AbstractRepositoryStrategy AbstractRepositoryStrategy.java(release:153) 19.08.2008 17:25:58 session has been already closed website

and this randomly:
-----------------------------------------------------------------------------------------------
WARN info.magnolia.module.workflow.jcr.JCRExpressionStore JCRExpressionStore.java(getHierarchyManager:293) 19.08.2008 17:25:45 The workflow expression session has pending changes. Will clean the session
java.lang.Exception
at info.magnolia.module.workflow.jcr.JCRExpressionStore.getHierarchyManager(JCRExpressionStore.java:293)
at info.magnolia.module.workflow.jcr.JCRExpressionStore.storeExpression(JCRExpressionStore.java:105)
at openwfe.org.engine.impl.expool.AbstractExpressionStore.loadEngineEnvironment(AbstractExpressionStore.java:136)
at openwfe.org.engine.impl.expool.SimpleExpressionPool.fetchEngineEnvironment(SimpleExpressionPool.java:406)
at openwfe.org.engine.impl.expool.CachedExpressionPool.fetchEngineEnvironment(CachedExpressionPool.java:232)
at openwfe.org.engine.impl.expool.SimpleExpressionPool.reschedule(SimpleExpressionPool.java:1330)
at openwfe.org.engine.impl.expool.SimpleExpressionPool.trigger(SimpleExpressionPool.java:1393)
at openwfe.org.time.Scheduler$Entry.trigger(Scheduler.java:490)
at openwfe.org.time.Scheduler.wakeup(Scheduler.java:461)
at openwfe.org.time.Scheduler$SchedulerThread.run(Scheduler.java:577)



 Comments   
Comment by Jan Haderka [ 19/Aug/08 ]

Please do not report 2 issues in one. As for the first one, message is harmless and it is already fixed - see MAGNOLIA-2301 for details.
As for second issue ... I doubt it happens randomly - from the stack trace you can see it is a scheduled task that is failing.

Any chance you can lookup your Expressions workspace to see if there is any content?
Does it happen only if you have started some workflow or even if there is no workflow running?
Thx.

Comment by Jan Haderka [ 21/Aug/08 ]

The Workflow/ExpressionStore issue seems like a race condition on startup. AbstractExpressionStore tries to first call loadExpression() method of the JCRExpressionStore and if this call fails with exception it will silently swallow the exception and call storeExpression() method instead. Since each of the methods obtain hierarchy manager it is possible to get session with pending changes in the second call. To get more insight we should wrap content of loadExpression() in the try/catch block and make sure any exceptions are properly reported.

Comment by swetha [ 17/Dec/08 ]

I have the exact same issue.
1. Default installation of Magnolia
2. No config changes
3. Login to Magnolia
4. Activate any web page which is present.

WARN info.magnolia.module.workflow.jcr.JCRExpressionStore JCRExpressionStore.j
ava(getHierarchyManager:293) 17.12.2008 19:42:59 The workflow expression sessio
n has pending changes. Will clean the session
java.lang.Exception
at info.magnolia.module.workflow.jcr.JCRExpressionStore.getHierarchyMana
ger(JCRExpressionStore.java:293)
at info.magnolia.module.workflow.jcr.JCRExpressionStore.storeExpression(
JCRExpressionStore.java:105)
at openwfe.org.engine.impl.expool.AbstractExpressionStore.loadEngineEnvi
ronment(AbstractExpressionStore.java:136)
at openwfe.org.engine.impl.expool.SimpleExpressionPool.fetchEngineEnviro
nment(SimpleExpressionPool.java:406)
at openwfe.org.engine.impl.expool.CachedExpressionPool.fetchEngineEnviro
nment(CachedExpressionPool.java:232)
at openwfe.org.engine.expressions.Environment.lookup(Environment.java:30
8)
at openwfe.org.engine.impl.expool.SimpleExpressionPool.lookupVariable(Si
mpleExpressionPool.java:1269)
at openwfe.org.engine.expressions.AbstractFlowExpression.lookupVariable(
AbstractFlowExpression.java:295)
at openwfe.org.engine.expressions.raw.XmlRawExpression.resolveExpression
(XmlRawExpression.java:327)
at openwfe.org.engine.expressions.raw.XmlRawExpression.resolveExpression
(XmlRawExpression.java:288)
at openwfe.org.engine.expressions.raw.RawExpression.preApply(RawExpressi
on.java:339)
at openwfe.org.engine.expressions.raw.RawExpression.launch(RawExpression
.java:381)
at openwfe.org.engine.impl.expool.SimpleExpressionPool.applyOrLaunch(Sim
pleExpressionPool.java:527)
at openwfe.org.engine.impl.expool.SimpleExpressionPool.launch(SimpleExpr
essionPool.java:565)
at openwfe.org.engine.impl.launch.SimpleXmlLauncher$1.run(SimpleXmlLaunc
her.java:453)

Because of this, activation is NEVER done. Please help in resolving this.

Comment by Jan Haderka [ 23/Jan/09 ]

Done as of r21684.

Generated at Mon Feb 12 03:35:40 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.