[MAGNOLIA-2427] replace custom thread pool with library Created: 12/Oct/08 Updated: 23/Jan/13 Resolved: 20/Jan/09 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | activation |
| Affects Version/s: | 3.6.3 |
| Fix Version/s: | 4.0 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Philippe Marschall | Assignee: | Jan Haderka |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | java5 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Patch included: |
Yes
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
The module exchange-simple uses it's own thread pool instead of a library. There is no need for this since there are mature, stable, tested and debugged libraries available that do this. The attached patch uses the backport of java.util.concurrent that as an easy migration path to JDK 1.5 in Magnlia 4. The patch also removes two unused variables and corrects some indentation issues. |
| Comments |
| Comment by Jan Haderka [ 12/Oct/08 ] |
|
Excellent. Thanks very much. I'll have a look and try to apply it soon. |
| Comment by Jan Haderka [ 14/Oct/08 ] |
|
Hi Philippe, |
| Comment by Philippe Marschall [ 14/Oct/08 ] |
|
I'll rewrite the patch to use edu.oswego.* then. |
| Comment by Jan Haderka [ 14/Oct/08 ] |
|
Thanks a lot. |
| Comment by Philippe Marschall [ 14/Oct/08 ] |
|
Use original util.concurrent instead of backport of JSR 166 |
| Comment by Philippe Marschall [ 14/Oct/08 ] |
|
Ok, here we go again. Some notes:
|
| Comment by Jan Haderka [ 20/Jan/09 ] |
|
Done as of r21484. Thanks again for the patch. |