[MAGNOLIA-2450] Invalid comparison for protocol Created: 27/Oct/08  Updated: 23/Jan/13  Resolved: 22/Dec/08

Status: Closed
Project: Magnolia
Component/s: mail
Affects Version/s: 3.6.1, 3.6.3
Fix Version/s: 4.0

Type: Bug Priority: Major
Reporter: Marcel van den Brink Assignee: Teresa Miyar
Resolution: Fixed Votes: 0
Labels: mail, protocol, url
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

In the code of the MgnlMultipartEmail there is at line 98 the following check:

DataSource fds = url.getProtocol().startsWith("file:")

The comparison includes a semicolumn, which will never be part of the protocol. This line should be changed to:

DataSource fds = url.getProtocol().startsWith("file")

According to the java implementation a protocol consists only of letters... and a colon ( : ) is not a letter.



 Comments   
Comment by Teresa Miyar [ 04/Dec/08 ]

fixed in refactoring of module MAGNOLIA-2492

Generated at Mon Feb 12 03:36:50 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.