[MAGNOLIA-2462] Freemarker templating exception does not trigger a 500 error code Created: 03/Nov/08  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: core, templating
Affects Version/s: 4.0
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Magnolia International Assignee: Philipp Bärfuss
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File patch.txt    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

I get some freemarker exceptions in paragraphs, but the error code for my page is still 200 - not sure if/how we can fix this properly at the moment but let's have a look at this.



 Comments   
Comment by Jan Haderka [ 04/Nov/08 ]

Can you please attach that exception? Is it ParseException or TemplateException? As far as I know currently code handles only TemplateExceptions but not ParseExceptions.
As for the error code, if you want to render yellow box with the details of the exception, you have to return 200 otherwise non commited response gets wiped out and error page is rendered instead and no error box appears.

Comment by Jan Haderka [ 04/Nov/08 ]

Patch that takes care of ParseExceptions and ensures they are rendered in FM yellow error box as well.

Comment by Magnolia International [ 04/Nov/08 ]

Not too keen on this patch, we shouldn't rewrite / change fm's exception handling.
I'm aware of the 200 vs 500 / commited vs non-commited problem, which is why i left this open

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:36:57 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.