[MAGNOLIA-2475] EditBar tag has misleading "paragraph" attribute - it should be "dialog" Created: 13/Nov/08 Updated: 23/Jan/13 Resolved: 14/Jan/09 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | taglibs |
| Affects Version/s: | 3.5.8 |
| Fix Version/s: | 4.0 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Magnolia International | Assignee: | Magnolia International |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Comments |
| Comment by Philipp Bracher [ 14/Nov/08 ] |
|
I don't think so. Considering the relation to the new bar it makes sense. The attribute is mainly used when you don't have a new bar (singleton paragraph). So it sets then the paragraph on the node and should be called paragraph and not dialog since the paragraph to be set might be named differently. |
| Comment by Magnolia International [ 14/Nov/08 ] |
|
ha, right, correct. But does that mean we need an extra attribute for when one once to edit (some of the) page properties using another bar/button that the main bar? |
| Comment by Philipp Bracher [ 14/Nov/08 ] |
|
hm, yes we probably need an extra attribute. Or the possibility to add extra buttons like you can do for the main bar. |
| Comment by Magnolia International [ 14/Jan/09 ] |
|
Only fixed on trunk (4.0) - please reopen if this is an issue for 3.6 |