[MAGNOLIA-2506] Samples: replace by dev-oriented samples Created: 11/Dec/08 Updated: 23/Jan/13 Resolved: 22/Jan/09 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | samples |
| Affects Version/s: | None |
| Fix Version/s: | 4.0 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Teresa Miyar | Assignee: | Teresa Miyar |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
Rationale: It's been a very long time we're bothered by our current samples module; it was rarely up-to-date, and it never really fulfilled both of the goals it tried to achieve: providing usable examples of Magnolia usage AND providing a showcase for template developers. Instead, we will now have a sample module geared towards template/module developers, which will certainly not show best-of-breed design and layout, but will attempt to encompass and demonstrate all features modules and templates can use. Details / concept at: Existing templates at: This module will also be used to execute a bunch of integration tests - for instance for rendering validation. |
| Comments |
| Comment by Magnolia International [ 08/Jan/09 ] |
|
I consistently get the following in my logs - please fix 2009-01-08 16:53:47,357 INFO info.magnolia.module.samples.filters.SampleFilter : Executing sample filter but bypass ./admin urls 2009-01-08 16:53:49,898 ERROR info.magnolia.cms.taglibs.Include : Paragraph main-sample-jsp not found for page /sample-jsp/main/0 java.lang.IllegalStateException: Paragraph main-sample-jsp not found for page /sample-jsp/main/0 at info.magnolia.cms.beans.config.ParagraphRenderingFacade.render(ParagraphRenderingFacade.java:88) at info.magnolia.cms.taglibs.Include.doEndTag(Include.java:216) at org.apache.jsp.templates.samples.templates.main_002dsample_jsp._jspx_meth_cms_005fincludeTemplate_005f0(main_002dsample_jsp.java:240) at org.apache.jsp.templates.samples.templates.main_002dsample_jsp._jspx_meth_cms_005fcontentNodeIterator_005f0(main_002dsample_jsp.java:214) |
| Comment by Magnolia International [ 12/Jan/09 ] |
|
The sample Freemarker paragraph throws this, when an image isn't selected: Expression content.image is undefined on line 9, column 38 in samples/paragraphs/main-sample-freemarker.ftl.
The problematic instruction:
----------
==> ${content.image} [on line 9, column 36 in samples/paragraphs/main-sample-freemarker.ftl]
|
| Comment by Magnolia International [ 22/Jan/09 ] |
|
The jsp sample paragraph displays a broken image if no image was uploaded. |