[MAGNOLIA-2524] AggregationState.decodeURI is wrong - review Created: 22/Dec/08 Updated: 23/Jan/13 Resolved: 15/Oct/09 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | None |
| Fix Version/s: | 4.2 |
| Type: | Task | Priority: | Major |
| Reporter: | Magnolia International | Assignee: | Jan Haderka |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||
| Task DoR: |
Empty
|
||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||
| Description |
|
(This method was previously in info.magnolia.cms.core.Path) We currently do URLDecoder.decode(uri, encoding);, which is wrong, since the 1st parameter of this method is supposed to be one parameter, not a complete URI. Besides, it is unclear why we have to do this at all - shouldn't it have be done by the container ? |
| Comments |
| Comment by Magnolia International [ 14/Oct/09 ] |
|
Request.getRequestUri() returns the encoded string.
|
| Comment by Jan Haderka [ 15/Oct/09 ] |
|
Instead of decoding whole URI only the selectors are now decoded. |