[MAGNOLIA-2528] Remove dependency to admincentral messages in MessagesManager Created: 30/Dec/08  Updated: 19/Dec/16  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: admininterface, core
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major
Reporter: Magnolia International Assignee: Philipp Bärfuss
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MAGNOLIA-1160 i18n, testing: MessagesManager should... Closed
depends upon MAGNOLIA-2273 Make MessagesManager easier to extend... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

MessagesManager.DEFAULT_BASENAME currently refers to a file which is in fact in the admincentral module. This a completely soft dependency, so the worse that could happen is that those messages aren't found - however, for isolation, cleanliness and testability, this shouldn't be the case.
We probably don't even need a default messages at all - or maybe a very limited one with just a couple of messages about Magnolia (version, build and so on? - although these informations are also provided by LicenseFileExtractor)

Since I'm adding tests for MessagesManager, I'll add a fake resource file in the core/test folders to work around this for now.



 Comments   
Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:37:35 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.