[MAGNOLIA-2621] Extract interface from MessagesManager Created: 13/Feb/09 Updated: 23/Jan/13 Resolved: 15/Feb/09 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | 4.0 |
| Fix Version/s: | 4.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | Manuel Molaschi | Assignee: | Fabrizio Giustina |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Patch included: |
Yes
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
Hi. I think that MessagesManager could be improved by allowing, via configuration, to add Messages implementations to be (on startup or on configuration changes) chained in newMessages method. |
| Comments |
| Comment by manuel.molaschi [ 13/Feb/09 ] |
|
Wait! I found an error |
| Comment by manuel.molaschi [ 13/Feb/09 ] |
|
the new patch |
| Comment by manuel.molaschi [ 13/Feb/09 ] |
|
Modified MessagesManager to make it abstract (all static methods, getInstance, and base abstract methods) |
| Comment by Fabrizio Giustina [ 15/Feb/09 ] |
|
Patch committed for 4.0-rc4. I assume this is ok for being committed in RCs: although the diff looks big it's just because of the creation of the base abstract class. All the signatures of public static methods in message manager are unchanged, and there is nothing changed also in the implementation of all the methods in the default message manager, just moved for easier subclassing. |
| Comment by Magnolia International [ 16/Feb/09 ] |
|
I avoided doing this for I'm pretty sure simply removing the final keyword from the MessagesManager class would have been enough for your purpose, pending a more complete cleanup in the next release; moreover [tests are now broken|http://hudson.magnolia-cms.com/job/magnolia_main-trunk-forked-tests/info.magnolia$magnolia-core/105/testReport/6. I'd rather avoid having to deal with this in the future, but I'm hoping to quickly find the reason why these tests are now failing and fix it. If not, I'll have to revert this - and will of course remove the final from MessagesManager, that was an obvious mistake. |