[MAGNOLIA-2624] Remove roles/groups selection from user preferences dialog Created: 15/Feb/09  Updated: 23/Jan/13  Resolved: 23/Feb/09

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 4.0
Fix Version/s: 4.0

Type: Improvement Priority: Major
Reporter: Fabrizio Giustina Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File preference-dialog.diff    
Issue Links:
duplicate
duplicates MAGNOLIA-2400 Split Roles/Groups assignment from Us... Closed
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

We are now reusing the user edit dialog for user preferences (link on the user name on top-right in adminCentral), with all the fields that are usually needed to create/edit an user by the security manager.
Anyway, this kind of dialog is intended for changing things like email or password, and the role selection is IMHO something totally unwanted. Keep in mind that this form will be used also by editors that usually neither know what those roles are. Clicking by error on the "remove" button near role or group selections can also lock down the user (ok, it's an user fault, but keep in mind the kind of users this dialog is intended for, as said they don't ever need to know anything about magnolia security).

Said so, the attached patch just adds a specific user-preference dialog that is used only from the link in adminCentral. Same as the "user edit" one but without any role/group selector.
I would like to commit it before 4.0 rc4, I am attaching a patch for now in order to get feedback from devs



 Comments   
Comment by Magnolia International [ 16/Feb/09 ]

This is a duplicate from MAGNOLIA-2400

Comment by Magnolia International [ 16/Feb/09 ]

Patch seems pretty trivial indeed, but this does not take security into account at all, so we still need to look into MAGNOLIA-2399

Comment by Magnolia International [ 16/Feb/09 ]

Will happily apply the patch, but we also need an update task.

Comment by Magnolia International [ 23/Feb/09 ]

Added update task myself. Done.

Generated at Mon Feb 12 03:38:31 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.