[MAGNOLIA-2670] Wrong links saved by fckeditor when the page path starts with a directory = context path Created: 24/Mar/09  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 4.0, 4.0.1
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Fabrizio Giustina Assignee: Philipp Bärfuss
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

This happens if you try to link a page which path starts with the same string as the context path, i.e.:

Any link to /myapp/page.html added from fckedit is converted to /page.html, stripping part of the url only because is similar to the context path.

This is done in SaveHandlerImpl line 467:

            String link = StringUtils.removeStart(src, MgnlContext.getContextPath());

The link added from fckedit doesn't have the context path from the beginning, so this check will remove part of the url. Removing the check will make links working when added from the UI, not sure if we need it to support manually written urls that may contain the context path



 Comments   
Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:38:57 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.