[MAGNOLIA-2671] <cmsu:simpleNavigation relativeLevels="true" fails Created: 24/Mar/09 Updated: 23/Jan/13 Resolved: 11/Dec/09 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | taglibs |
| Affects Version/s: | 4.0.1, 4.1.1 |
| Fix Version/s: | 4.1.3, 4.2.2 |
| Type: | Bug | Priority: | Major |
| Reporter: | Oliver Knorr | Assignee: | Jan Haderka |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Windows Vista Business SP1 |
||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Description |
|
After upgrading from Magnolia 3.6.3 to 4.0.1, the tag <cmsu:simpleNavigation relativeLevels="true" startLevel="0" endLevel="1" /> does not print out the list of subpages anymore. Like with |
| Comments |
| Comment by Oliver Knorr [ 07/Nov/09 ] |
|
I just had a fresh look at this, now with Magnolia 4.1.1, where the problem still exists. I tried to find a new fix without reverting to the old Resource.java version. It obviously has to do with the single usage of the Resouce class in SimpleNavigationTag, which is the first line inside the doEndTag() method: public int doEndTag() throws JspException { Content activePage = Resource.getCurrentActivePage(); The problem disappeared for me, when I replaced getCurrentActivePage() with getActivePage(), like this: public int doEndTag() throws JspException { Content activePage = Resource.getActivePage(); I'm still a bit wary of suggesting this as a patch, as I don't know what the difference between getCurrentActivePage() and getActivePage() is supposed to be. Except for a deprecation notice, the Javadoc for the two methods is identical... |
| Comment by Jan Haderka [ 25/Nov/09 ] |
|
Let me guess: the issue actually occurs only when the tag is in the template after the cms:contentNodeIterator, but if you move the cmsu:simpleNavigation before the iterator, the issue will not occur. Is that correct? |
| Comment by Oliver Knorr [ 27/Nov/09 ] |
|
Hello Jan, |