[MAGNOLIA-2710] Make MgnlUserManager easier to extend Created: 03/May/09  Updated: 23/Jan/13  Resolved: 03/May/09

Status: Closed
Project: Magnolia
Component/s: core, security
Affects Version/s: 4.0
Fix Version/s: 4.1, 4.0.2

Type: Improvement Priority: Major
Reporter: Fabrizio Giustina Assignee: Fabrizio Giustina
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

MgnlUserManager should be easy to extend if someone needs to provide a different implementation of MgnlUser.
There are a few places where it instantiates new users using "new MgnlUser(node)", it would be better if all of them are factored out in a single method.



 Comments   
Comment by Fabrizio Giustina [ 03/May/09 ]

done, added the following method that can be overridden:

 protected MgnlUser userInstance(Content node) {
        return new MgnlUser(node);
    }

Comment by Magnolia International [ 04/May/09 ]

fixed for 4.0.2 too

Generated at Mon Feb 12 03:39:20 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.