[MAGNOLIA-2715] DefaultNodeData.getParent() always returns null Created: 06/May/09  Updated: 11/Aug/09  Resolved: 11/Aug/09

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Magnolia International Assignee: Jan Haderka
Resolution: Incomplete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Comments   
Comment by Jan Haderka [ 05/Aug/09 ]

I'm not really sure what you meant by the "always" part in the description of this issue.
The only case in which parent can be null is when the default constructor is used, which happens in case the Node data can't be retrieved (and in tests). Looking at the history of the DefaultContent/Content it always seemed to be the case.
Since r27010, DefaultContent will set parent for the NodeData explicitly when using the default constructor. We could possibly create another constructor taking parent node as it's only parameter and deprecate original default constructor to make it clear that it is not meant to be used.

Leaving the issue open for review of changes made and clarification of the "always" part.

Comment by Magnolia International [ 05/Aug/09 ]

I'm not really sure what you meant by the "always" part in the description of this issue.

Me neither. Someone should have banged me on the head when this issue was created, asking for more details.

Comment by Philipp Bärfuss [ 06/Aug/09 ]

Could have been related to MAGNOLIA-2760

Comment by Magnolia International [ 11/Aug/09 ]

Really can't remember. It might have been when working on the imaging module, and it might be that I was actually talking about MockNodeData instead, really no idea. If this shows up again, I'll try to remember this issue

Generated at Mon Feb 12 03:39:24 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.