[MAGNOLIA-2759] RepositoryBrowserPage incorrectly assumes tree name = repository name Created: 03/Jun/09  Updated: 23/Jan/13  Resolved: 15/Jun/09

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 4.0.1, 3.6.5
Fix Version/s: 4.1.1

Type: Bug Priority: Major
Reporter: Fabrizio Giustina Assignee: Fabrizio Giustina
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File MAGNOLIA-2759.patch    
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

RepositoryBrowserPage in fckeditor module can be configured in order to browse multiple repositories (actually website and dms). The configuration of "browsableRepositories" is however a list of tree names, and the RepositoryBrowserPage assumes that the name of the repository always matches the name of the tree.
For example there is no way to configure a "website-jcr" tree since it will look for a "website-jcr" repository too.

It should be fixed by using TreeHandlerManager to get the correct repository name from the tree handler name.



 Comments   
Comment by Fabrizio Giustina [ 03/Jun/09 ]

Fixed in revision 25678 by using TreeHandlerManager. Added a fallback to the old behaviour if the tree is not found (also if it will never happen with a working configuration)

Comment by Magnolia International [ 03/Jun/09 ]

Reverted commit - will review and reapply patch as soon as 4.1 final is out. Too close to release, sorry.

Comment by Magnolia International [ 15/Jun/09 ]

patch reapplied, added comments. thanks.

Generated at Mon Feb 12 03:39:49 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.