[MAGNOLIA-2794] Register some sort of RecoveryFilter for when the filter chain is not correctly configured Created: 17/Jun/09  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 4.1
Fix Version/s: None

Type: Improvement Priority: Major
Reporter: Magnolia International Assignee: Philipp Bärfuss
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Currently, if no filter chain is available, we end up with ugly NPEs.

If the /server/filters node is not available at all, we could for instance instanciate rootFilter as some sort of filter that lets Magnolia start and give the user a chance to fix the installation.

Another issue is that activation is obviously broken if the filter configuration is broken. The following scenario needs to be taken into account:

  • filters broken on author
  • user decides to delete the filter nodes and reimport a backup. If not careful (and if we still have the deletion=immediate deactivation), the filters are also removed from the public instance.
  • if the import succeeds (which will probably need a restart anyway for the filters to be reinitialized), the imported configuration still can't be activated to the public instance(s), since those have no filters - thus no activation filter.

TODO - there are related issues, link and/or fix them !



 Comments   
Comment by Jan Haderka [ 04/Dec/13 ]

while technically not possible, this should be switchable, otherwise you might end up with this emergency measure becoming accessible on public instance that comes up automatically while recovering from some disaster in data centre giving access to the instance to just about anyone, so probably you would keep it switched off on production environment, enabling the option only in case you actually screwed up some config change.

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:40:10 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.