[MAGNOLIA-2805] Can't deploy webapp from a directory that has a "+" symbol in its path Created: 30/Jun/09  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 3.6.6, 4.0.2, 4.1.1
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Magnolia International Assignee: Philipp Bärfuss
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

OSX 10.5.57 - tomcat, jetty, ...


Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

While this is probably not a very common use-case, we ran into this problem with integration tests on osx 10.5.7

Indeed, tmp files are now going to /var/folders/some-unique-path - and (sometimes?) this path contains +'s:

2009-06-30 16:23:23.200::INFO:  Extract jar:file:/Users/gjoseph/Dev/magnolia/svn-branches/magnolia-bundle-3.6/magnolia-bundled-webapp/target/magnolia-bundled-webapp-3.6.6-SNAPSHOT.war!/ to /var/folders/Ca/Cay4JfEtFGyfVhgQhPjJ4U+++TI/-Tmp-/Jetty_0_0_0_0_9345_magnolia-bundled-webapp-3.6.6-SNAPSHOT.war__magnoliaAuthor__ovqsl9/webapp
D
DEBUG  info.magnolia.cms.servlets.MgnlServletContextListener MgnlServletContextListener.java(contextInitialized:164) 30.06.2009 16:23:26  rootPath is /private/var/folders/Ca/Cay4JfEtFGyfVhgQhPjJ4U+++TI/-Tmp-/Jetty_0_0_0_0_9345_magnolia-bundled-webapp-3.6.6-SNAPSHOT.war__magnoliaAuthor__ovqsl9/webapp, webapp is webapp

(rootPath is set correctly here)

Somewhere along the road, this path gets url-decoded, resulting in such warnings:

WARN   info.magnolia.cms.util.ClasspathResourcesUtil ClasspathResourcesUtil.java(collectFiles:160) 30.06.2009 16:23:26  missing file: /private/var/folders/Ca/Cay4JfEtFGyfVhgQhPjJ4U   TI/-Tmp-/Jetty_0_0_0_0_9345_magnolia-bundled-webapp-3.6.6-SNAPSHOT.war__magnoliaAuthor__ovqsl9/webapp/WEB-INF/classes

Still, the repository seems to be correctly loaded:

INFO   info.magnolia.jackrabbit.ProviderImpl ProviderImpl.java(init:176) 30.06.2009 16:23:26  Loading repository at /private/var/folders/Ca/Cay4JfEtFGyfVhgQhPjJ4U+++TI/-Tmp-/Jetty_0_0_0_0_9345_magnolia-bundled-webapp-3.6.6-SNAPSHOT.war__magnoliaAuthor__ovqsl9/webapp/repositories/magnolia (config file: /private/var/folders/Ca/Cay4JfEtFGyfVhgQhPjJ4U+++TI/-Tmp-/Jetty_0_0_0_0_9345_magnolia-bundled-webapp-3.6.6-SNAPSHOT.war__magnoliaAuthor__ovqsl9/webapp/WEB-INF/config/repo-conf/jackrabbit-bundle-derby-search.xml)

but the startup ends up failing with

 
2009-06-30 16:23:33.035::WARN:  Failed startup of context org.mortbay.jetty.webapp.WebAppContext@d816d6{/magnoliaAuthor,jar:file:/Users/gjoseph/Dev/magnolia/svn-branches/magnolia-bundle-3.6/magnolia-bundled-webapp/target/magnolia-bundled-webapp-3.6.6-SNAPSHOT.war!/}
java.lang.RuntimeException: javax.jcr.PathNotFoundException: modules
	at info.magnolia.module.ModuleManagerImpl.startModules(ModuleManagerImpl.java:346)
	at info.magnolia.module.ui.ModuleManagerWebUI.onStartup(ModuleManagerWebUI.java:80)
	at info.magnolia.cms.beans.config.ConfigLoader.load(ConfigLoader.java:138)
	at info.magnolia.cms.beans.config.ConfigLoader.<init>(ConfigLoader.java:107)
	at info.magnolia.cms.servlets.MgnlServletContextListener$1.exec(MgnlServletContextListener.java:178)

Verified this isn't test or jetty specific by simply renaming my apache-tomcat-5.5.27 folder to apache+tomcat-5.5.27 and saw exactly the same symptoms.



 Comments   
Comment by Magnolia International [ 30/Jun/09 ]

Related issues:
http://www.netbeans.org/issues/show_bug.cgi?id=167139
http://discussions.apple.com/thread.jspa?threadID=2041458

Indicating we might also run into other issues if we use the java system temp folder (java.io.tmpdir)

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:40:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.