[MAGNOLIA-2810] Dialog node type: fix all our bootstrap files and create update task! Created: 07/Jul/09 Updated: 23/Jan/13 Resolved: 10/Mar/10 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | admininterface, templating, workflow |
| Affects Version/s: | 4.1, 4.0.2 |
| Fix Version/s: | 4.3 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Magnolia International | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | Not Specified | Time Spent: | Not Specified |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Sub-Tasks: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
When updating or even installing a clean instance, there are tons of unnecessary log messages such as: WARN: Dialog definitions should be of type contentNode but [/modules/abc/dialogs/paragraphs/xyz] is of type content. we should fix our own content! |
| Comments |
| Comment by Zdenek Skodik [ 17/Feb/10 ] |
|
There appears the questions related to this topic repeatedly, so I'm going to fix it (btw 4.2.x was marked as fix version previously). |
| Comment by Zdenek Skodik [ 17/Feb/10 ] |
|
list is attached ~ 42 items/14 modules |
| Comment by Zdenek Skodik [ 22/Feb/10 ] |
|
Changing dialog node type seems to me ok for standard dialog definitions, but I don't like it in case of generics at all. info.magnolia.module.admininterface.DialogHandlerManager try { if(dialogNode.getItemType().equals(ItemType.CONTENT)){ log.warn("Dialog definitions should be of type contentNode but [" + dialogNode.getHandle() + "] is of type content."); } } catch (RepositoryException e) { log.error("Can't check for node type of the dialog node [" + dialogNode.getHandle() + "]: " + ExceptionUtils.getMessage(e), e); throw new IllegalStateException("Can't check for node type of the dialog node [" + dialogNode.getHandle() + "]: " + ExceptionUtils.getMessage(e)); } I don't see any really important reason why we should do such a check especially when the type actually have no impact on functionality, |
| Comment by Jan Haderka [ 22/Feb/10 ] |
|
There is a reason why this issue is linked to another - original issue - As for generic tabs - we can either change type of the subfolders (pages, controls, teasers to ItemContent.CONTENT_NODE if the warning bothers you too much. Or (imho) we can keep it as is, since indeed those are not the dialogs and should not be recognized as such, so the warning is perfectly appropriate and once we enforce the type, they will no longer be mapped. Unrelated to the issue: please distinguish between "generics" which refers to the erasure of types in java code and "generic" which is just a folder name for generic tabs in STK. |
| Comment by Zdenek Skodik [ 23/Feb/10 ] |
|
yep I am also for the generic tabs organization under folders, I was only that the content type check goes directly against it, |
| Comment by Philipp Bärfuss [ 09/Mar/10 ] |
|
I suggest the following improvements
|
| Comment by Federico Grilli [ 09/Mar/10 ] |
|
Yes, that would ideally be the next steps but I wanted to test this better before making it generic and reusable. |
| Comment by Federico Grilli [ 10/Mar/10 ] |
|
Will create a subtask for this improvement
|