[MAGNOLIA-2816] png and swf mimetypes have ; in their value when updating from a version prior to 3.6.3 Created: 21/Jul/09  Updated: 18/Sep/09  Resolved: 20/Aug/09

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: None
Fix Version/s: 3.6.7, 3.6.8, 4.0.3, 4.1.1

Type: Bug Priority: Major
Reporter: Magnolia International Assignee: Teresa Miyar
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

The bootstrap file is fine, but the update tasks registered for 3.6.4 set these mime types to image/png; and application/x-shockwave-flash; respectively, where the ; should not be there.



 Comments   
Comment by Magnolia International [ 07/Aug/09 ]

Existing instances need to be fixed. This update task being registered for 3.6.4, just modifying the task itself it won't fix any.

Comment by Magnolia International [ 10/Aug/09 ]

Here's an example untested patch of how this could be fixed.

Before it is applied and this is closed, we need to

  • write unit tests that validate the behaviour for this version handler. There are too many cases to test manually. (depends on the original Magnolia version that was installed, then on the update path)
  • merge it to the 3.6 and 4.0 branches appropriately ! (with the same/adapted tests!)

The above comment is obviously valid for all update-related issues that are still pending.

edit: the above was related to an attached sample patch; it's now been committed to the trunk

Comment by Teresa Miyar [ 19/Aug/09 ]

Patch has been tested and adapted for 3.6 branch

Comment by Magnolia International [ 19/Aug/09 ]

what about the 4.0 branch ?

Generated at Mon Feb 12 03:40:23 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.