[MAGNOLIA-2821] Do not print warning from PropertyValuesTask when value found is same as the one task was supposed to update to Created: 24/Jul/09  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 4.1
Fix Version/s: 4.5.x

Type: Improvement Priority: Trivial
Reporter: Jan Haderka Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: maintenance, quickwin
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

e.g.

Property "configurationClass" was expected not to exist at /modules/data/trees/data, but exists with value 
"info.magnolia.module.data.trees.WorkflowDataAdminTreeConfig" and was going to be created with value "info.magnolia.module.data.trees.WorkflowDataAdminTreeConfig".


 Comments   
Comment by Magnolia International [ 24/Jul/09 ]

Well, these tasks are (supposed to be) very "strict". If a property is supposed to be absent at the time, the warning is relevant, in the sense that it is an unexpected situation, and good-citizen tasks are supposed to handle only expected situations.
Is it just a warning or is the task failing ?

Comment by Jan Haderka [ 24/Jul/09 ]

Just a warning. It's just that the message seems bit silly, saying it can't be created with value xyz, because it already exists with value xyz. I think it would be easier to read and understand if in this case message was something like:

Property "configurationClass" was expected not to exist at /modules/data/trees/data, but is already configured with expected value.
Comment by Magnolia International [ 24/Jul/09 ]

I agree the message isn't the best

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:40:26 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.