[MAGNOLIA-2875] TreeHandlerManager should set properties recursively to allow flexible tree configurations Created: 25/Sep/09 Updated: 23/Jan/13 Resolved: 13/Nov/09 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | admininterface |
| Affects Version/s: | 4.1.1 |
| Fix Version/s: | 4.2 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Will Scheidegger | Assignee: | Magnolia International |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | TreeConfiguration, TreeHandlerManager, config, tree | ||
| Remaining Estimate: | 5m | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | 5m | ||
| Attachments: |
|
| Template: |
|
| Patch included: |
Yes
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: |
| Description |
|
The way trees are configured at this time is not very flexible: It's all hardcoded in configuration classes. And all you can to is select the configuration class, choose the starting path of the tree and switch between tree and browse mode. Instead of simply selecting a configuration class by setting the configurationClass value it would be much better to have a ConfigurableTreeConfiguration class which reads its configuration at runtime from the config tree. So instead of providing a configurationClass nodeData one would provide a configuration contentNode which contains all the trees configuration info. When I tried to do this, I noticed however that this contentNode was never turned into a bean. This is because the TreeHandlerManager does not set the properties recursively. The attached patch fixes this problem. In a later step, I will provide a first version of the ConfigurableTreeConfiguration too. |
| Comments |
| Comment by Philipp Bärfuss [ 02/Oct/09 ] |
|
We have not yet moved to supporting content2bean for trees and dialogs because this will be changed in the 5.0 version completely. But this minimal patch won't hurt in my opinion. Thanks! |
| Comment by Philipp Bärfuss [ 13/Oct/09 ] |
|
Will Scheidegger has published a configuration class which can be used once the patch has been applied: --> http://www.fastforward.ch/web/ff/dokumentation/entwickler/magnolia_configurable_tree.html Thanks! |
| Comment by Magnolia International [ 13/Nov/09 ] |
|
Patch applied, thanks Will ! |