[MAGNOLIA-2878] Dialog class and saveHandler is no more used/called Created: 02/Oct/09  Updated: 23/Jan/13  Resolved: 21/May/10

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 4.1
Fix Version/s: 4.3.2

Type: Bug Priority: Critical
Reporter: Benoit Segaert Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: JPEG File excelrenderer-saveHandler.jpg     JPEG File module-class.jpg    
Issue Links:
relation
is related to MAGNOLIA-2907 System ignores class data field when ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

On a new module, the class and saveHandler parameter of a Dialog is no more used.

I have 2 examples (cf. attachements)

  • In the Excel Renderer module that I changed for the compatibility with templating kit (saveHandler)
  • In another module, with the using of the class

I added tracing in my code:

public class WSTDownloadLinkListDialog extends ParagraphEditDialog{

public WSTDownloadLinkListDialog(String name, HttpServletRequest request, HttpServletResponse response, Content configNode)

{ super(name, request, response, configNode); log.info("WSTDownloadLinkListDialog instanciated"); }

And in Excel Renderer module:

public class ExcelTransformerSaveHandler extends UUIDSaveHandler {
protected void processBinary(Content node, String name) throws RepositoryException

{ super.processBinary(node, name); removePreRenderedProperty(name, node); log.info("processBinary"); }

protected void processString(Content node, String name, int type, int encoding, String[] values, String valueStr) throws PathNotFoundException, RepositoryException, AccessDeniedException {
super.processString(node, name, type, encoding, values, valueStr);
final DialogControlImpl control = getControl(name);
log.info("pprocessString General");
if (control instanceof UUIDDialogControl)

{ log.info("pprocessString Control"); removePreRenderedProperty(name, node); }

}

I can see the dialogs but these classes are never instantiated and the method are never called (constructor for WSTDownloadLinkListDialog ).



 Comments   
Comment by Philipp Bärfuss [ 02/Oct/09 ]

This is probably only the case for dialogs assigned to paragraphs. Otherwise save handlers seem to work.

Comment by Benoit Segaert [ 02/Oct/09 ]

Effectively, both examples,, I explained are referred from paragraphs.

Comment by Philipp Bärfuss [ 27/Oct/09 ]

MAGNOLIA-2907 is related. Both problems result from the fact that the generic paragraph dialog handler is now 'delegating' to the dialog (or better using its configuration) but not really using an additional instance for that.

Comment by Benoit Segaert [ 02/Nov/09 ]

Philipp,

Can we expected a solution for version 4.2? Because I need it for my project.

If you don't have time can you give me some directions where I can looking for in the code?

Generated at Mon Feb 12 03:41:00 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.