[MAGNOLIA-2878] Dialog class and saveHandler is no more used/called Created: 02/Oct/09 Updated: 23/Jan/13 Resolved: 21/May/10 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 4.1 |
| Fix Version/s: | 4.3.2 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Benoit Segaert | Assignee: | Philipp Bärfuss |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
On a new module, the class and saveHandler parameter of a Dialog is no more used. I have 2 examples (cf. attachements)
I added tracing in my code: public class WSTDownloadLinkListDialog extends ParagraphEditDialog{ public WSTDownloadLinkListDialog(String name, HttpServletRequest request, HttpServletResponse response, Content configNode) { super(name, request, response, configNode); log.info("WSTDownloadLinkListDialog instanciated"); }And in Excel Renderer module: public class ExcelTransformerSaveHandler extends UUIDSaveHandler { protected void processString(Content node, String name, int type, int encoding, String[] values, String valueStr) throws PathNotFoundException, RepositoryException, AccessDeniedException { } I can see the dialogs but these classes are never instantiated and the method are never called (constructor for WSTDownloadLinkListDialog ). |
| Comments |
| Comment by Philipp Bärfuss [ 02/Oct/09 ] |
|
This is probably only the case for dialogs assigned to paragraphs. Otherwise save handlers seem to work. |
| Comment by Benoit Segaert [ 02/Oct/09 ] |
|
Effectively, both examples,, I explained are referred from paragraphs. |
| Comment by Philipp Bärfuss [ 27/Oct/09 ] |
|
|
| Comment by Benoit Segaert [ 02/Nov/09 ] |
|
Philipp, Can we expected a solution for version 4.2? Because I need it for my project. If you don't have time can you give me some directions where I can looking for in the code? |