[MAGNOLIA-2957] multiple editCode controls cannot coexsit in the same dialog Created: 25/Nov/09  Updated: 23/Jan/13  Resolved: 25/Nov/09

Status: Closed
Project: Magnolia
Component/s: gui
Affects Version/s: 4.2.1
Fix Version/s: 4.2.2

Type: Bug Priority: Major
Reporter: Toby O'Rourke Assignee: Federico Grilli
Resolution: Fixed Votes: 1
Labels: attachment, dialog
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File fix_multiple_edit_code_controls.patch    
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

DialogEditCode writes out a javascript function which replaces the onclick event of the form on which the control has been placed when codepress is used. When more than one control is placed in a form, this replacement overwrites itself such that only one control works properly. No data is saved from the other controls, the corresponding properties are subsequently removed from the JCR.

The supplied patch chains the functions, thereby removing the problem. As a side effect it removes the limitation that enabling codepress supersedes the dialog's own specific event handler.



 Comments   
Comment by Federico Grilli [ 25/Nov/09 ]

Thanks Toby.

Generated at Mon Feb 12 03:41:47 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.