[MAGNOLIA-3005] Content does not correctly implement equals() Created: 13/Jan/10  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 4.2.3
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Nils Breunese Assignee: Philipp Bärfuss
Resolution: Won't Do Votes: 1
Labels: vpro
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Testcase included:
Yes
Date of First Response:

 Description   

The Content class does not seem to correctly implement an equals() method. Running the following Groovy code via the Groovy Shell returns false, while I am pretty sure it should return true.

ContentEqualsTest.groovy
import info.magnolia.cms.util.*

def repository = "website"
def path = "/demo-project"
def c1 = ContentUtil.getContent(repository, path)
def c2 = ContentUtil.getContent(repository, path)
return c1.equals(c2)

Correctly implementing equals() and hashCode() is pretty important for working with objects like these. I ran into this bug while filling a Set with references to pages and noting that the same page was in the Set multiple times. I haven't checked if there are more objects that do not correctly implement equals() and/or hashCode(), but there may be more.



 Comments   
Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:42:15 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.