[MAGNOLIA-3050] Add missing methods to BinaryNodeData for getting/setting attributes Created: 01/Feb/10 Updated: 03/Dec/13 Resolved: 03/Dec/13 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major |
| Reporter: | Fabrizio Giustina | Assignee: | Daniel Lipp |
| Resolution: | Outdated | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
I noticed only recently that BinaryNodeData has methods for setting attributes like: setAttribute(String name, String value) setAttribute(String name, Calendar value) but it misses the method for setting Longs or Doubles (I was wondering why the image size is set as a string and not as a long in jcr, this is probably the reason). Also for getting attributes it only has: public String getAttribute(String name) { which is already strange since the setter already supports also Calendars. What about cleaning it up in order to allow all the available types? we could maybe just add a getNodeData(String name) method similar to the one in Content (making clear that a binary node data can have other node data nested)? |
| Comments |
| Comment by Philipp Bärfuss [ 02/Feb/10 ] |
|
This is something which really gives me headache once a while. I tried to clean up things a bit ( Knowing that any change will have side effects we can probably not improve that before 5.0. I could agree if nd.getNodeData() is only available in a specific BinaryNodeData interface. |
| Comment by Daniel Lipp [ 03/Dec/13 ] |
|
ContentAPI is deprecated so we won't improve BinaryNodeData. |