[MAGNOLIA-3103] Install page fails to render properly when task name or description are not set Created: 26/Feb/10  Updated: 19/Dec/16  Resolved: 04/Aug/15

Status: Closed
Project: Magnolia
Component/s: admininterface, updatemechanism
Affects Version/s: 4.3
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Jan Haderka Assignee: Unassigned
Resolution: Outdated Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screenshot-Magnolia install-update ... - Chromium.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

See the attachment.
To reproduce add the task with null in a name and/or description field.



 Comments   
Comment by Jan Haderka [ 26/Feb/10 ]

from IRC:
(11:32:42) gjoseph: why is this a bug?
(11:32:52) gjoseph: just instanciate your tasks properly
(11:33:53) gjoseph: or am i missing something?
(11:47:21) rah003: yes and no ... if the task allows to be instantiated with the null, then template should be able to cope with it and vice versa - if template can't cope with it, then task should fail on init
(11:55:16) gjoseph: re:task - there are cases where it's "relevant2 to have null arguments (delegates for ex) - so i'm not inclined to fix it either way
(11:56:22) rah003: re:task, do you mind if I just fix the template?
(11:56:44) gjoseph: yes
(11:56:54) rah003: in many cases we pass in empty strings - I really don't like that
(11:57:03) gjoseph: for descriptions
(11:57:17) gjoseph: not for "name"
(12:00:20) rah003: oh really? look at CacheModuleVersionHandler or DMS or Data or Wrokflow or should I search some more?
(12:03:57) gjoseph: in CacheMVH, the only example I see is for the one task of 4.1, as far as I can see all the other uses of "" are for "nested" tasks (mostly in ArrayDelegateTask here)
(12:06:17) gjoseph: i don't really like the ""s, mind you, but i'm not keen on "fixing" the template, because I'm not keen on allowing nulls for these paremeters. the "correct" fix would be to disallow nulls in the ctor like you suggested, and have an ArrayDelegateTask that somehow bypasses this limitation. would pbly require some api changes
(12:06:41) gjoseph: and there are a few more changes i'd like to do to make the MVHs less verbose, more fluid, but no clear idea nor plan at the moment
(12:07:09) rah003: fair enough, I'm not saying we have to change now, but would like to keep this ticket open
(12:08:08) gjoseph: let's paste this conversation in it

Comment by Michael Mühlebach [ 04/Aug/15 ]

We're closing this issue as outdated as it was reported for 4.4.x or earlier versions which are no longer supported. Don't hesitate to reopen or create a new ticket in case this is still relevant and you'll experience it on 4.5.x or later versions.

Generated at Mon Feb 12 03:43:13 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.