[MAGNOLIA-3171] move CacheHeadersFilter back to core Created: 31/Mar/10  Updated: 26/Nov/13  Resolved: 26/Nov/13

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 4.3.1
Fix Version/s: None

Type: Improvement Priority: Major
Reporter: Fabrizio Giustina Assignee: Unassigned
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

talking about the filter described in MAGNOLIA-2011:
the filter for settings headers for client-side cache has nothing to do with server-side caching, so there is no reason why it should be in magnolia-module-cache. It has been moved there incorrectly a long time ago, we should move it back to core.

to refrain:

  • the cache module is responsible for storing magnolia generated content and resources server side
  • http headers for browser cache is a totally different thing and they are not related at all with server side caching. The SetExpirationHeaders executor tied to the cache module is a big mistake and also the filter has nothing to do with the cache module.

We could rename cacheHeaders filter to HttpHeadersFilter or anything else if the "cache" name makes things confused...



 Comments   
Comment by Magnolia International [ 01/Apr/10 ]

It IS related; the cache module decides (or can decide, or influence) what "hints" (http headers) we send back to the browser.
I agree that a specific, separate filter can be useful/needed for setting these headers in some cases, but I don't see the point of calling the executor a "big mistake" (it most definitely uses information from the cache)

Generated at Mon Feb 12 03:43:53 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.