[MAGNOLIA-3174] Error page not rendered anymore after an exception on a template Created: 02/Apr/10 Updated: 04/Nov/15 Resolved: 04/Nov/15 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | rendering, templating |
| Affects Version/s: | 4.3.1 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Fabrizio Giustina | Assignee: | Fabrizio Giustina |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: |
| Description |
|
Not sure what has changed, but looks like that after 4.3-m3 response pages in case of errors during the template rendering have been broken. Same page, same error: in previous versions the error page is properly served, in 4.3 final/4.3.1 we only get a blank page with a "response already committed" in tomcat logs. The flush of the response is done in info.magnolia.module.templating.renderers.AbstractTemplateRenderer.renderTemplate() in a finally block. Should we move the out.flush() outside the finally block to fix it? Is anybody aware of the reason why it should be there? |
| Comments |
| Comment by Michael Mühlebach [ 04/Nov/15 ] |
|
Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes. |