[MAGNOLIA-3194] css: rect() needs comma-separated value Created: 07/May/10  Updated: 23/Jan/13  Resolved: 07/Jun/10

Status: Closed
Project: Magnolia
Component/s: admininterface, gui, integration tests
Affects Version/s: None
Fix Version/s: 4.3.2

Type: Bug Priority: Major
Reporter: Magnolia International Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File clip-rect-comma.patch     Text File enablecss_in_tests.patch    
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

While browsers seem to be happy about the following css snippet:

clip: rect(0 0 100px 0);

.. the cssparser used by HtmlUnit isn't; it's following the spec a little closer, and enforce those values to be comma separated.
This would be the correct syntax

clip:rect(0, 0, 100px, 0);

Attached is a patch that fixes the issue for magnolia-gui and m-m-admininterface. (hoping there are no other places where this property is set that weren't found with find . ! -path "/target/" ! -name ".java" ! -path "/.svn/*" -exec grep -H rect( {} \;)

Additional patch updates the version of HtmlUnit used in integration tests to 2.7, enables css parsing, and consequently fixes the issues we've had with integration tests since MAGNOLIA-3180 (MAGNOLIA-3180 did not break anything per se, since the tests were not checking the rendered results; the real issue is that we were disabling css in those tests, thus preventing the tree javascript to do its job; now that HtmlUnit supports css @import, we were able to enable css parsing)

http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-Rect
http://www.w3.org/TR/1998/REC-CSS2-19980512/visufx.html#value-def-shape



 Comments   
Comment by Philipp Bärfuss [ 07/Jun/10 ]

Released with 4.3.2

Generated at Mon Feb 12 03:44:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.