[MAGNOLIA-3198] SimpleUrlPattern.URL_CHAR_PATTERN block newlines chars Created: 11/May/10  Updated: 01/Mar/16  Resolved: 11/May/10

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 4.3.1
Fix Version/s: 4.3.2

Type: Bug Priority: Minor
Reporter: Fabrizio Giustina Assignee: Fabrizio Giustina
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MAGNOLIA-3150 SimpleUrlPattern do not accept all th... Closed
is causing MAGNOLIA-3268 SimpleUrlPattern crashes (infinite lo... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

After the change in MAGNOLIA-3150 SimpleUrlPattern.URL_CHAR_PATTERN should allow any character, but it actually misses the newline char.

This is of course not commonly used in URLs, but the problem is that a URL with the newline char (%0A) now brings the magnolia login screen (also on a public website), which is undesired

For example a call to:
http://mymagnoliasite.com/test%0A.html
with utf8 enabled should just end up in a 404, and not in the Magnolia login screen.

This can be easily fixed by changing the * regexp (any char except for the newline).



 Comments   
Comment by Fabrizio Giustina [ 11/May/10 ]

regexp fixed + unit test added

Generated at Mon Feb 12 03:44:09 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.