[MAGNOLIA-3204] aggregation state loses all information on forwards Created: 18/May/10  Updated: 23/Jan/13  Resolved: 07/Jun/10

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 4.3.1
Fix Version/s: 4.3.2

Type: Bug Priority: Critical
Reporter: Philipp Bärfuss Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File MAGNOLIA-3204.patch    
Issue Links:
causality
is causing MGNLETK-27 Multi site support and virtualURIMapp... Closed
dependency
depends upon MAGNOLIA-3203 aggregation state: original uri reset... Closed
relation
is related to MGNLETK-28 multi-site support: fixing various is... Closed
is related to MAGNOLIA-3814 MgnlContext.getAggregationState().get... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

The Problem

The aggregation state is set to null on each forward. This is problematic as we also store the locale and site in the aggregation state. As a consequence all this information is lost after a virtual uri mapping which forwards.

Example:

  1. request to /de/page/param.html
    • locale is set to de
    • current uri is /page/param.html
  2. virtual uri mapping
    • forward to /page.html?param
  3. re-execution
    • ContentTypeFilter resets the aggregation state
    • locale is now the default locale:en

Solution

We could simply not reset the aggregation state but this conflicts with MAGNOLIA-3203 (resetting original URI on forward). So we can either fix MAGNOLIA-3203 or reset the aggregation state partially.



 Comments   
Comment by Philipp Bärfuss [ 18/May/10 ]

Attached a solution having the least amount of impact:

  • set the original uri (even if this is wrong)
  • only reset the original uri -> keep all other values
Generated at Mon Feb 12 03:44:12 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.