[MAGNOLIA-3214] pageIterator does not correctly replace the "current" node after it finishes looping Created: 24/May/10 Updated: 04/Nov/15 Resolved: 04/Nov/15 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | taglibs |
| Affects Version/s: | 4.3.1, 4.2.4 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major |
| Reporter: | Nickolaus Wing | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Template: |
|
| Patch included: |
Yes
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: |
| Description |
|
pageIterator relies on info.magnolia.cms.taglibs.Resource.restoreCurrentActivePage() to restore the current node after execution. However, restoreCurrentActivePage() simply assumes that you wish to set getMainContent() as the current node. It seems more friendly to save off the current content node before execution, and restore it afterwards. The included patch does exactly that. File to be patched is magnolia-taglib-cms/.../pageIterator.java. |
| Comments |
| Comment by Nickolaus Wing [ 11/Jun/10 ] |
|
I'd really like to see this patch get picked up - it's essential for our sidebar strategy, which I'm hoping to be able to package up as a standalone module. |
| Comment by Michael Mühlebach [ 04/Nov/15 ] |
|
Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes. |