[MAGNOLIA-3223] SimpleNavigationTag: Allow HTML in navTitle field Created: 01/Jun/10  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: taglibs
Affects Version/s: 4.2.3
Fix Version/s: None

Type: Improvement Priority: Minor
Reporter: Will Scheidegger Assignee: Philipp Bärfuss
Resolution: Won't Do Votes: 0
Labels: escape, escapeXml, simplenavigation
Remaining Estimate: 10m
Time Spent: Not Specified
Original Estimate: 10m

Attachments: Text File escapeXmlInNavTitle_flag.patch    
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

HTML is definitely not allowed in page titles nor in url path segments. But there is no reason why it should not be allowed in the display string of a navigation item. Therefore I added a "escapeXmlInNavTitle" flag to the SimpleNavigationTag (default set to "true" which complies with the behavior so far. The way it works:

  • When "escapeXmlinNavTitle" is set to false
  • and the display string was read from the "navTitle" field (not from the "title" or "name")
  • and it contains HTML

the HTML is not escaped and therefore displayed as intended. This will allow for stuff like partially colored or bold nav item text etc. like "why <b>simple</b> is <b>beautiful</b>"



 Comments   
Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:44:24 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.