[MAGNOLIA-3233] error on activate recursively a content with utf8 enabled and parent node composed by special chars (ex. "/fòò/bàr") Created: 22/Jun/10 Updated: 09/Jul/14 Resolved: 19/Jul/10 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | activation |
| Affects Version/s: | 4.3.1, 4.3.2 |
| Fix Version/s: | 4.3.3, 4.4 |
| Type: | Bug | Priority: | Blocker |
| Reporter: | Luca Boati | Assignee: | Luca Boati |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | activation, unicode | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Description |
|
magnolia.uft8.enabled = true activating recursively "/fòò" or activating "bàr" node solution proposed:
|
| Comments |
| Comment by Jan Haderka [ 28/Jun/10 ] |
|
In BaseSyndicatorImpl you wrap call to encode() in try/catch, but in SimpleSyndicator you don't. Any reason for different treatment? |
| Comment by Luca Boati [ 28/Jun/10 ] |
|
Hi Jan |
| Comment by Jan Haderka [ 28/Jun/10 ] |
|
It was more then just the imports in the UnicodeNormalizationFilter and while i agree that it was still readable in this case, it is better to avoid making such changes with the code change at all. (tho I admit that I make it sometimes by mistake too) |
| Comment by Luca Boati [ 28/Jun/10 ] |
|
In the UnicodeNormalizationFilter I didn't re-format parts of code not belonging to the modification I had to do to fix the bug...anyways.. we agree. |
| Comment by Jan Haderka [ 19/Jul/10 ] |
|
Committed fix breaks activation when public instance has magnolia.utf8.enabled=false or when public instance is older version before this feature have been introduced. |
| Comment by Jan Haderka [ 19/Jul/10 ] |
|
Thanks. |