[MAGNOLIA-3252] Version should not ignore SNAPSHOT classifier Created: 15/Jul/10 Updated: 04/Nov/15 Resolved: 04/Nov/15 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | updatemechanism |
| Affects Version/s: | 4.3.2 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Nils Breunese | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 1 |
| Labels: | vpro | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Description |
|
We have used some Magnolia and STK/ETK SNAPSHOT jars for a while on our central development repository and upgraded to final releases when they became available. The version numbers in the configuration workspace still say "4.3.2-SNAPSHOT" and "1.3.1-SNAPSHOT" though. Javadoc for info.magnolia.module.model.Version says: "Format is x.y.z-classifier. y,z and classifier are optional. The classifier string is ignored in version comparisons." I feel this could result in problems if version handler are changed during the SNAPSHOT phase. We install the SNAPSHOT jar, the module version is set to a SNAPSHOT version in the configuration workspace, but when we later upgrade to the release jar the Version class doesn't think the release version number is more recent, so the version handler won't be executed again. I feel it would be good to modify the Version class to reflect that version "x.y.z" is more recent than "x.y.z-SNAPSHOT". |
| Comments |
| Comment by Bert Leunis [ 19/Jul/10 ] |
|
I'll add some extra info that was exchanged on the user list. Bert said: The versionhandlers should recognize the move from 1.3.1-SNAPSHOT to 1.3.1 as an upgrade. Is that correct? Jan answered: Bert replied: I see. But apart from that, shouldn't at least the version number be updated? Jan replied: Yeah, it should be. |
| Comment by Leo Lozes [ 22/Feb/13 ] |
|
It looks like this is not going to be fixed soon, so can you at least provide a manual about how to handle this situation? |
| Comment by Michael Mühlebach [ 04/Nov/15 ] |
|
Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes. |