[MAGNOLIA-3311] nodebuilder: add an exception handler which logs but proceeds with the processing Created: 06/Oct/10 Updated: 20/Feb/15 Resolved: 21/Oct/10 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Ondrej Chytil | Assignee: | Ondrej Chytil |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: |
| Description |
|
Error handler which simply logs warnings messages into stacktrace. |
| Comments |
| Comment by Magnolia International [ 20/Oct/10 ] |
|
after review/discussion, we realized this isn't the way to go. Let's revert this |
| Comment by Jan Haderka [ 21/Oct/10 ] |
|
I would not be so sure about rollback of this error handler. Right now, except for this handler there are only 2 others - Strict that re-throws the exception and TaskLog that requires InstallContext. So effectively we are limiting use of NodeBuilder to installation or cases where we want to fail on error. While it might be useful for example from groovy shell to be able to use the NodeBuilder and proceed even on exceptions. |