[MAGNOLIA-333] remove cyclic dependencies Created: 17/Apr/05 Updated: 22/Mar/06 Resolved: 22/Mar/06 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | 2.01 |
| Fix Version/s: | 3.0 Beta 1 |
| Type: | Task | Priority: | Major |
| Reporter: | Fabrizio Giustina | Assignee: | Fabrizio Giustina |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoR: |
Empty
|
| Date of First Response: |
| Description |
|
[was deleted] The magnolia code has a lot of cyclic dependencies between packages, We could start by defining the correct order of dependencies (e.g. First candidates: move Path to core and exchange servlet to exchange.simple? |
| Comments |
| Comment by Fabrizio Giustina [ 17/Apr/05 ] |
|
inlined some comparators in info.magnolia.cms.core.Content to reduce dependencies on info.magnolia.cms.util |
| Comment by Fabrizio Giustina [ 17/Apr/05 ] |
|
moved Path to core. This removes any direct dependency from cms.core to cms.util |
| Comment by Fabrizio Giustina [ 17/Apr/05 ] |
|
moved ExchangeServlet to info.magnolia.cms.exchange.simple.SimpleExchangeServlet |
| Comment by Fabrizio Giustina [ 17/Apr/05 ] |
|
the bigger problem now is the cyclic dependency between info.magnolia.cms.core and info.magnolia.cms.beans.config. We should remove any dependency to info.magnolia.cms.beans.config from info.magnolia.cms.core, but at the moment this isn't so easy and it will require moving to core most of the classes from beans.config. |
| Comment by Fabrizio Giustina [ 01/May/05 ] |
|
Moved ItemType to core |
| Comment by Fabrizio Giustina [ 03/May/05 ] |
|
moved SystemProperty to core |
| Comment by Fabrizio Giustina [ 07/May/05 ] |
|
moved info.magnolia.cms.core.util.Access to core. Circular dependency between core and security now |
| Comment by Fabrizio Giustina [ 15/May/05 ] |
|
see |
| Comment by Fabrizio Giustina [ 15/May/05 ] |
|
removed dependency from info.magnolia.cms.i18n to info.magnolia.cms.gui: removed utility methods in TemplateMessagesUtils which took a DialogSuper as argument (Philipp, please be careful in adding new inter-package dependencies) |
| Comment by Boris Kraft [ 15/Jun/05 ] |
|
Fabrizio, can you comment on the state of this and either close or move issue to 2.2DP? |
| Comment by Fabrizio Giustina [ 15/Jun/05 ] |
|
ciclic dependencies have been partially removed, but there is still something to do. Moving to 2.2, we will try to split magnolia modules in separate subprojects and this will help. |
| Comment by Fabrizio Giustina [ 22/Mar/06 ] |
|
still some cyclic dependencies in core, but the split into separate modules helped a lot. |