[MAGNOLIA-3349] Port Virtual URI mappings to a Registry Created: 29/Oct/10 Updated: 29/Jan/18 Resolved: 02/May/17 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | Virtual URI mappings |
| Affects Version/s: | 4.3.8 |
| Fix Version/s: | 5.5.6, 5.6 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Christian Ringele | Assignee: | Oanh Thai Hoang |
| Resolution: | Done | Votes: | 2 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 6d 6.5h | ||
| Original Estimate: | 5d | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | Saigon 87, Saigon 88, Saigon 89, Saigon 90, Saigon 91, Saigon 92, Saigon 93 | ||||||||||||||||||||||||||||||||||||||||||||
| Story Points: | 8 | ||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
In order to support folder-hierarchy within Virtual URI mappings config, VirtualURIManager should be ported to an AbstractRegistry.
Side notes:
Original title: Allow subfolders/nodes in the observed 'virtualURIMapping' module nodes When having a lot of virtualURIMappings registered in a module, it can be quite hard to keep the overview. I added a patch of this class, which does that. Code should be checked for core quality, was implemented very quickly. |
| Comments |
| Comment by Michael Mühlebach [ 04/Nov/15 ] |
|
Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes. |
| Comment by Michael Mühlebach [ 03/Mar/17 ] |
|
Jan: Use registries for virtual URI mappings. This solves this issues and many others. |
| Comment by Mikaël Geljić [ 15/Mar/17 ] |
|
| Comment by Mikaël Geljić [ 17/Mar/17 ] |
|
Outcome from architects (cc ejervidalo had pmundt rkovarik):
|
| Comment by Mikaël Geljić [ 02/May/17 ] |
|
The VirtualUriRegistry is successfully implemented, within the new magnolia-virtual-uri module. The new module means that we had to relocate APIs (VirtualURIMapping, VirtualUriFilter), while the VirtualURIManager is now deprecated in favor of the registry (book-keeping) and the filter (evaluation). Significant backward compatibility is provided, mainly by a couple things:
Taking the opportunity of the relocation, follow-up As a side note, the new magnolia module was developed with 5.4.x-compliant APIs; that should leave a few options open. |