[MAGNOLIA-3409] Wrong comment is used when restoring version Created: 25/Nov/10 Updated: 02/Jul/13 Resolved: 04/Dec/12 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | workflow |
| Affects Version/s: | 4.4 |
| Fix Version/s: | 4.5.7 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Andreas Weder | Assignee: | Milan Divilek |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||
| Description |
|
When restoring a version, it seems that the comment of a particular version is not restored. I've created a node and activated it. I then deleted the node, activated the change, but rejected the subsequently created work item. I activate and rejected again. I've then opened the Versions dialog in AdminCentral on the node and restored to a previous version (2nd version from above, dating 11/25/10 4:07pm). |
| Comments |
| Comment by Andreas Weder [ 25/Nov/10 ] |
|
This looks like a misunderstanding from my side: the last version of the list is not the restored version, actually, but seems to be a snapshot taken before the restoration. After all, if only one version of a page exists, the list is empty. In this case, shouldn't the comment of the 4:19pm version read "Automatically created version prior restoration"? |
| Comment by Milan Divilek [ 04/Dec/12 ] |
|
Port to 5.0 can't be done right now. Because 5.0 doesn't support metadata. This issue should be ported after refactoring VersionCommand. |
| Comment by Jan Haderka [ 04/Dec/12 ] |
|
Actually I would leave the version there. Method is protected so there might be other implementations that would want to print also version number in the comment or use it for other purposes. |