[MAGNOLIA-3483] Date type properties: Content.setNodeData() expects Calendar object, while Content2Bean passes Date object Created: 29/Dec/10  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: content2bean, core
Affects Version/s: 4.3.8
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Felix Rabe Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: quickwin
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Observation: While working on REG-91, I used info.magnolia.cms.core.Content.setNodeData(String, Calendar) to set the value of a type="Date" JCR property. Later, I just assumed Content2Bean likewise to pass a Calendar object to my bean setter methods - see the state of AuthenticationTokenConfig.java in commit r40983. This did not work, and it turns out that the Content2Bean mechanism actually passes a Date object for type="Date" JCR properties. (I found out by changing the parameter of the setter method from Calendar to Object and stepping into the method in debugging mode.)

Problem: Representing the same JCR data using two different Java types just feels plain wrong.

Proposed solution: Use the same (sane) Java type for the JCR API and for the Content2Bean mechanism in Magnolia 5.0.



 Comments   
Comment by Magnolia International [ 19/Jan/11 ]

A (failing) testcase for this would be great. If that indeed fails, it should probably be fixed before 5.0.

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:46:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.