[MAGNOLIA-3521] PropertyInitializer should be pluggable. Created: 20/Jan/11 Updated: 14/Mar/12 Resolved: 14/Mar/12 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | 4.3.8, 4.4.1 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Danilo Ghirardelli | Assignee: | Unassigned |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||
| Description |
|
I don't know if it's un der refactoring right now, but just in case, I'm adding this. |
| Comments |
| Comment by Magnolia International [ 26/Jan/11 ] |
|
So far, there is no configuration mechanism for the replacement of such components, but we could think about it. Let me know what you think. |
| Comment by Danilo Ghirardelli [ 10/Feb/11 ] |
|
Property initialization is always "special" in the various ioc framework, always developed with some "border line" implementation... I don't know much about pico best practices about properties initialization, but my opinion is that this new implementation is a bit overkill but misses the central point to be pluggable. Unfortunately pluggability for property resolver is a real and pressing problem (at least for me), and I honestly don't see the point of having the current hierarchy of classes if I couldn't choose which use or to plug an extension... Given that the properties initialization is somewhat "external" for the container, I would have kept a simpler version that just uses a class declared in the context params (with fallback to the default initializer), without involving Pico. At least this is my opinion. |
| Comment by Jan Haderka [ 14/Mar/12 ] |
|
Most of the methods of the class are gone as of Magnolia 4.5 and it will be removed completely. |